From a7926ff9009ed81b078749fdd64a2e4682535b70 Mon Sep 17 00:00:00 2001 From: Fabian Schieder Date: Mon, 30 Mar 2026 23:22:44 +0200 Subject: [PATCH] Fix potential undefined index notices in compare.php for attribute values --- compare.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/compare.php b/compare.php index 64ae1b0..0f5a72d 100644 --- a/compare.php +++ b/compare.php @@ -119,7 +119,7 @@ if ($_SERVER['REQUEST_METHOD'] === 'POST' && isset($_POST['remove_compare'])) { $attr): ?> - + @@ -127,9 +127,9 @@ if ($_SERVER['REQUEST_METHOD'] === 'POST' && isset($_POST['remove_compare'])) { if (isset($productAttrVals[$pId][$attrId])) { $valRow = $productAttrVals[$pId][$attrId]; if (!empty($valRow['valueString'])) { - echo htmlspecialchars($valRow['valueString']); + echo htmlspecialchars($valRow['valueString'] ?? ''); } elseif (!empty($valRow['valueNumber']) || $valRow['valueNumber'] === '0.00' || $valRow['valueNumber'] === 0) { - echo htmlspecialchars(floatval($valRow['valueNumber'])) . " " . htmlspecialchars($attr['unit']); + echo htmlspecialchars((string)floatval($valRow['valueNumber'])) . " " . htmlspecialchars($attr['unit'] ?? ''); } elseif ($valRow['valueBool'] !== null) { echo $valRow['valueBool'] ? 'Ja' : 'Nein'; } else {